feat: Add Task<ExecResult> extension method ThrowOnFailure#1448
Merged
HofmeisterAn merged 1 commit intodevelopfrom May 17, 2025
Merged
Conversation
✅ Deploy Preview for testcontainers-dotnet ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
HofmeisterAn
changed the title
ExecResult extension ThrowOnFailureTask<ExecResult> extension method ThrowOnFailure
HofmeisterAn
deleted the
feature/add-exec-result-extensions-throw-on-failure
branch
riezebosch
reviewed
May 17, 2025
riezebosch
left a comment
riezebosch
left a comment
There was a problem hiding this comment.
nice that you added my suggestion!
| /// <exception cref="ExecFailedException">Thrown if the exit code is not in the list of success exit codes.</exception> | ||
| public static async Task<ExecResult> ThrowOnFailure(this Task<ExecResult> execTask, params long[] successExitCodes) | ||
| { | ||
| successExitCodes = successExitCodes == null || successExitCodes.Length == 0 ? new long[] { 0 } : successExitCodes; |
There was a problem hiding this comment.
could've used successExitCodes?.Any() here
|
|
||
| exceptionInfo.AppendLine(); | ||
| exceptionInfo.AppendLine(" Stderr: "); | ||
| exceptionInfo.Append(string.Join(Environment.NewLine, stderrLines)); |
There was a problem hiding this comment.
why combine StringBuilder with linq?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds an
ExecResultextension methodThrowOnFailurewhich throws an exception if a command run inside a container fails. This makes it easier to fail fast without having to manually check the result every time.Why is it important?
-
Related issues